I’ve made these a few times now and they’ve become my go-to pattern for a partially elasticated waist. They work incredibly well in a stretch cotton. The pocket detail and side seams really set it apart while making it fun to sew.
For the pair of shorts photographed I went with a 4″ inseam.